Skip to content

Code Quality: Added design and basic functionality for the upcoming Shelf feature #16673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 6, 2025
Merged

Code Quality: Added design and basic functionality for the upcoming Shelf feature #16673

merged 8 commits into from
Jan 6, 2025

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Jan 6, 2025 •
edited by yaira2
Loading

Resolved / Related Issues
This is a continuation for the Shelf feature #12490

Steps used to test these changes

  • Dropped a couple of files and folders to validate they're being added to the list

Screenshots
image

@yaira2 yaira2 self-requested a review January 6, 2025 01:35
@yaira2 yaira2 changed the title Added design and basic functionality for Shelf Code Quality: Added design and basic functionality for Shelf Jan 6, 2025
@yaira2 yaira2 changed the title Code Quality: Added design and basic functionality for Shelf Code Quality: Added design and basic functionality for the upcoming Shelf feature Jan 6, 2025
yaira2
yaira2 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 1024760 into files-community:main Jan 6, 2025
5 checks passed
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 6, 2025
@d2dyno1 d2dyno1 deleted the d2dyno/dropzone2 branch January 6, 2025 02:52
@Lamparter Lamparter mentioned this pull request Jan 6, 2025
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d2dyno1 @yaira2