Skip to content

Code Quality: Self-defined IStorageProviderQuotaUI instead of using StorageProviderStatusUI.FromAbi #16965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 21, 2025

Resolved / Related Issues

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Open a props window of OneDrive folder

Confirmed working well:
image

CC @dongle-the-gadget

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Mar 21, 2025
@0x5bfa 0x5bfa changed the title Code Quality: Self-defined IStorageProviderQuotaUI instead of StorageProviderStatusUI.FromAbi Code Quality: Self-defined IStorageProviderQuotaUI instead of using StorageProviderStatusUI.FromAbi Mar 21, 2025
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-SyncHelperRefactoring branch from 76b7f2c to 7b952b5 Compare March 21, 2025 16:23
Copy link
Contributor

@dongle-the-gadget dongle-the-gadget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Mar 21, 2025
@yaira2 yaira2 merged commit 3a057b8 into files-community:main Mar 21, 2025
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-SyncHelperRefactoring branch March 21, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants