Fix: Fixed sorting issues with #-# numbered files

[nethbotheju]

Resolved / Related Issues
Fixes #17009

Steps used to test these changes
For the test, I have created another single file and copied the NaturalStringComparer code to it and tested the changes.

[dongle-the-gadget]

Potential copyright issue, as NaturalStringComparer is MIT licensed (so copy of license required), but the copyright notice isn't updated properly.

[0x5bfa]

Confirmed working well!

Potential copyright issue, as NaturalStringComparer is MIT licensed (so copy of license required), but the copyright notice isn't updated properly.

I did a quick search but all of pieces of code are fully made by community members only for Files.

---

FWIW, .NET 10 will bring a numeric comparison feature so this may no longer needed in the future.

[dongle-the-gadget]

Author credits NaturalStringComparer and using GitHub Code Search on that specific repo does indicate a match.

[0x5bfa]

Can you link me to that repo?

[dongle-the-gadget]

https://github.com/GihanSoft/NaturalStringComparer/blob/main/src/NaturalStringComparer/NaturalComparer.cs

[0x5bfa]

@nethbotheju @yaira2 we may as well add a license acknowledgement for NaturalStringComparer:

{
	// Credit: https://github.com/GihanSoft/NaturalStringComparer
	public sealed class NaturalStringComparer
	{
	}
}

[nethbotheju]

@0x5bfa I have updated the file with the license acknowledgement comment.

[Lamparter]

There are a couple formatting issues here, otherwise LGTM

Looks like this file had some formatting issues as well before this change was made

[nethbotheju]

@Lamparter Thanks for the formatting suggestions.

[yaira2]

FWIW, .NET 10 will bring a numeric comparison feature so this may no longer needed in the future.

@0x5bfa agreed, this should be a temporary solution. That said, I would like to check with the author before using their code in this manner.

[yaira2]

@GihanSoft thank you for your work on NaturalStringComparer. We're looking to use this in Files without bringing in the entire package. Do you have any objections with the way this is being implemented?

[GihanSoft]

Sorry being late
Use it as you please
I'll be glad if you mentioned it on readme or about of app but not mandatory.

For advice:

1. Are you using last version of code? I recently changed entire algorithm. Becoming faster and more memory efficient.

2. Shouldn't you either use my code in future or use .net-10 source from start to have constance behavior?

[yaira2]

@GihanSoft thank you for the response. We'll be happy to add a notice to our about page.

Are you using last version of code? I recently changed entire algorithm. Becoming faster and more memory efficient.

@nethbotheju can you confirm?

Shouldn't you either use my code in future or use .net-10 source from start to have constance behavior?

.net10 is still in preview so we'll be on .net9 for some time.

[nethbotheju]

@yaira2 Yes, it uses the latest version of the code, which was updated 5 months ago

[yaira2]

@nethbotheju can you please add a notice to the 'third party libraries' section on the about page?

[nethbotheju]

@yaira2 Are you referring to the https://files.community/docs/features/integrations section of the website?

[dongle-the-gadget]

I think it is NOTICE.md

[nethbotheju]

@yaira2 I have updated the NOTICE.md file with the NaturalStringComparer licenses

[yaira2]

@nethbotheju @GihanSoft thank you!

[yaira2]

LGTM