Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Added setting to enable Omnibar #17018

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Apr 4, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Added setting to enable Omnibar

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed setting hides existing breadcrumb bar and displays Omnnibar instead

@yaira2 yaira2 force-pushed the ya/OmnibarSetting branch from c5ec599 to 8f1c3d4 Compare April 4, 2025 14:44
@yaira2 yaira2 requested a review from 0x5bfa April 4, 2025 14:57
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 4, 2025
@yaira2 yaira2 merged commit ee6674e into main Apr 4, 2025
8 checks passed
@yaira2 yaira2 deleted the ya/OmnibarSetting branch April 4, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants