-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added support for changing encoding when extracting ZIP files #17022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Apr 6, 2025
yaira2
reviewed
Apr 8, 2025
yaira2
reviewed
Apr 8, 2025
yaira2
reviewed
Apr 8, 2025
yaira2
reviewed
Apr 8, 2025
yaira2
reviewed
Apr 8, 2025
yaira2
reviewed
Apr 8, 2025
yaira2
reviewed
Apr 8, 2025
Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
Co-authored-by: Yair <[email protected]> Signed-off-by: oxygen-dioxide <[email protected]>
yaira2
reviewed
Apr 8, 2025
d674f60
to
e6bb8e4
Compare
yaira2
previously approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZIP file specifications historically use the system's local encoding (e.g., CP936 for Chinese, Shift_JIS for Japanese) to store filenames, rather than UTF-8. This causes cross-language compatibility issues: for example, filenames created by Japanese users (Shift_JIS) will appear as garbled text when extracted by Chinese users (using GBK/CP936), and vice versa. English-speaking users rarely encounter this issue since most legacy encodings are Latin-compatible, but it remains critical for multilingual users.
This PR adds an encoding selection option during ZIP extraction. Users can manually override the default system encoding (e.g., to Shift_JIS, UTF-8, GBK, Big5, etc.) to ensure filenames are decoded correctly. (defaults to system encoding to reserve backward compatibility)
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
I'm a Chinese user, so I don't know whether and how the encoding issue affects English users. Below is how I test this on Simplified Chinese windows.
japanese-example.zip
The file names in this zip file are Japanese encoded in Shift-JIS. Here are the results of extraction:

Extracted with Shift-JIS (correct)
Extracted with default encoding (previous behaviour which is incorrect):

TODO