Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Improved display of singular and plural strings #17036

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Apr 10, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Tested each modified string

@yaira2 yaira2 marked this pull request as draft April 10, 2025 03:17
@yaira2 yaira2 marked this pull request as ready for review April 10, 2025 15:10
@yaira2
Copy link
Member Author

yaira2 commented Apr 10, 2025

@XTorLukas with the exception of the Status Center, this should take care of the remaining strings.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 10, 2025
@yaira2 yaira2 merged commit e993f5e into main Apr 10, 2025
8 checks passed
@yaira2 yaira2 deleted the ya/String branch April 10, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Change all multiple localized singular and plural strings to a single ICU message format string
1 participant