-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Code Quality: Refactored command titles and subtitles for clarity and consistency #17146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Normally, all the changes I had in mind have been implemented. It's up to you to tell me if everything suits you or if there are any changes to be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors various UI command titles and subtitles to improve clarity and consistency across the Files application.
- Updated labels and descriptions provide more context (e.g., specifying “in Windows Terminal,” “in the current view”).
- Changes span multiple command strings to align wording and improve user comprehension.
Comments suppressed due to low confidence (3)
src/Files.App/Strings/en-US/Resources.resw:2439
- Changing 'Cut' to 'Move' may alter the intended behavior; verify that the implementation aligns with this new terminology if the change is intentional.
<value>Move selected {0, plural, one {item} other {items}} to the clipboard</value>
src/Files.App/Strings/en-US/Resources.resw:3025
- Changing 'Undo' to 'Revert' might modify the intended semantics of the command; please confirm that this wording accurately reflects the functionality.
<value>Revert the last file operation</value>
src/Files.App/Strings/en-US/Resources.resw:3028
- Changing 'Redo' to 'Repeat' may lead to ambiguity in command behavior; verify that this change is consistent with the underlying functionality.
<value>Repeat the last file operation</value>
I am assuming we can't grab the name of the user's set default terminal, to make this string as accurate as we can. |
No, currently it is just a fixed string |
Just to clarify, actions have two strings. |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.