Skip to content

Feature: Added option to browse all icon files in file picker #17158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

Lamparter
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files
  2. Navigated to the properties window of a folder
  3. Opened the customise folder icon dialogue
  4. Tried selecting all the different options

@yaira2 yaira2 requested review from 0x5bfa, yaira2 and Copilot and removed request for 0x5bfa May 26, 2025 20:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the folder customization dialog to display additional icon file filters in the open file picker. Key changes include adding a new filter option for icon files in the picker and introducing a new localized resource for the icon files filter.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Files.App/ViewModels/Properties/CustomizationViewModel.cs Added a new icon file filter option using a combined list of extensions
src/Files.App/Strings/en-US/Resources.resw Introduced a localized resource for the icon files filter

@yaira2 yaira2 changed the title Feature: Displayed all extensions that can be used as a folder icon in open dialog Feature: Added option to browse all icon files in file picker May 27, 2025
@Lamparter Lamparter requested a review from yaira2 May 27, 2025 07:21
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 27, 2025
@yaira2 yaira2 merged commit fea128e into files-community:main May 27, 2025
6 checks passed
@Lamparter Lamparter deleted the properties-foldericon branch May 27, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Show all extension that can be used as folder icon
2 participants