Skip to content

chore(firebase_messaging): update example app to prove iOS message handlers work as intended #9292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 9, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Aug 3, 2022

Description

See title.

Related Issues

fixes #6290
fixes #8857

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@@ -200,3 +200,68 @@ Next, the worker must be registered. Within the entry file, **after** the `main.

Next restart your Flutter application. The worker will be registered and any background messages will be handled via this file.

### Handling Interaction
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kevinthecheung, I've just noticed that this section from the previous documentation is missing on the Firebase docs. I've just reinstated it, let me know if this is acceptable. Thanks!

@russellwheatley russellwheatley changed the title docs(messaging): update example app to prove iOS message handlers work as intended docs(firebase_messaging): update example app to prove iOS message handlers work as intended Aug 4, 2022
@russellwheatley russellwheatley changed the title docs(firebase_messaging): update example app to prove iOS message handlers work as intended chore(firebase_messaging): update example app to prove iOS message handlers work as intended Aug 4, 2022
@iosephmagno
Copy link

Hello @russellwheatley can you please check if your example is affected by #9300 ?

@russellwheatley russellwheatley merged commit 91d8aa7 into master Aug 9, 2022
@russellwheatley russellwheatley deleted the @russell/messaging-6290 branch August 9, 2022 12:32
@firebase firebase locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: messaging type: infrastructure Improvements to the codebase
Projects
None yet
5 participants