belt sanding stream_writer #5152
Open
+670
−434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
commented
May 16, 2025
|
|
||
| writer->cons_cnt = 0UL; | ||
| writer->cons_max = cons_max; | ||
| /* writer->out_sync already set */ |
There was a problem hiding this comment.
kinda confused where out_sync gets set... I probably missed it
There was a problem hiding this comment.
oh nvm I found it lol
| } | ||
|
|
||
| int err = fd_io_istream_snapshot_http_read( ctx->http, out, dst_max, &sz ); | ||
| while( out_cur<out_end ) { |
There was a problem hiding this comment.
ohh smart... so we can set a frag_sz_max for the stream writer and repeatedly fill up to frag_sz_max with calls to fd_io_istream_snapshot_http_read which is capped at the size of the HTTP resp buffer.
|
|
||
| for(;;) { | ||
| uchar const * prev = cur; | ||
| while( out_cur<out_end ) { |
There was a problem hiding this comment.
And same here, nice!
| ulong * cons_seq; /* cons_seq[ 2*cons_idx+i ] caches cons_fseq[ cons_idx ][i] */ | ||
| ulong volatile ** cons_fseq; /* cons_fseq[ cons_idx ] points to consumer fseq */ | ||
| /* Each consumer reports a 'frag sequence number' and the 'stream offset' */ | ||
| # define FD_STREAM_WRITER_CONS_SEQ_STRIDE 2UL |
There was a problem hiding this comment.
hmm why the define in the middle of the stream writer struct?
ripatel-fd
force-pushed
the
ripatel/snapshot-restore-beltsanding
branch
3 times, most recently
from
1f61afc to
60a9ad8
Compare
… ripatel/snapshot-restore-beltsanding
ripatel-fd
force-pushed
the
ripatel/snapshot-restore-beltsanding
branch
from
60a9ad8 to
ec0003d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.