Skip to content

SLATE: add support for ufl.replace #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Mar 3, 2025

Description

This PR adds support for replacing symbolic UFL expressions within SLATE. This is required in order to use fieldsplit on variational problems defined using SLATE.

Copy link

github-actions bot commented Mar 3, 2025

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8233 ran6527 passed1694 skipped12 failed

@pbrubeck
Copy link
Contributor Author

pbrubeck commented Mar 7, 2025

Ideally we would want SLATE classes to inherit from BaseForm, so that we can properly support ufl.replace and ufl.derivative on them.

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake default8249 ran7521 passed727 skipped1 failed

@pbrubeck pbrubeck force-pushed the pbrubeck/linear-solver branch 6 times, most recently from 3063f4f to 395168e Compare March 19, 2025 16:10
Base automatically changed from pbrubeck/linear-solver to master March 21, 2025 17:08
@pbrubeck pbrubeck closed this Apr 22, 2025
@pbrubeck pbrubeck force-pushed the pbrubeck/slate-fieldsplit branch from e124fa7 to 88e019a Compare April 22, 2025 09:00
@pbrubeck pbrubeck reopened this Apr 22, 2025
@pbrubeck pbrubeck force-pushed the pbrubeck/slate-fieldsplit branch from 4374a94 to 5b8bd68 Compare April 22, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant