Skip to content

Add option to build Docker containers manually #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release
Choose a base branch
from
Open

Add option to build Docker containers manually #4272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2a4865
Add option to build Docker containers manually
connorjward Apr 30, 2025
60ad053
fixup
connorjward Apr 30, 2025
50c0c0b
Merge remote-tracking branch 'origin/release' into connorjward/docker…
connorjward May 1, 2025
5f927df
Skip zenodo check and fix docker tag
connorjward May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,18 @@ on:
description: Docker image tag
type: string
secrets:
# Docker login information
DOCKERHUB_USER:
required: true
DOCKERHUB_TOKEN:
required: true
workflow_dispatch:
inputs:
tag:
description: Docker image tag
type: string

jobs:
# Firedrake container (just Firedrake)
# Firedrake only
docker_build_vanilla:
strategy:
fail-fast: false
Expand Down Expand Up @@ -48,7 +52,7 @@ jobs:
tag: ${{ inputs.tag }}
secrets: inherit

# # Firedrake container (Firedrake and friends)
# Firedrake and friends
docker_build_firedrake:
needs: docker_merge_vanilla
uses: ./.github/workflows/docker_build.yml
Expand All @@ -72,27 +76,7 @@ jobs:
tag: ${{ inputs.tag }}
secrets: inherit

# # Firedrake container with TeX
docker_build_docdeps:
needs: docker_merge_vanilla
uses: ./.github/workflows/docker_build.yml
with:
os: Linux
platform: linux/amd64
target: firedrake-docdeps
tag: ${{ inputs.tag }}
dockerfile: docker/Dockerfile.docdeps
secrets: inherit

docker_merge_docdeps:
uses: ./.github/workflows/docker_merge.yml
needs: docker_build_docdeps
with:
target: firedrake-docdeps
tag: ${{ inputs.tag }}
secrets: inherit

# # Firedrake container with Jupyter notebooks
# Firedrake with Jupyter notebooks
docker_build_jupyter:
needs: docker_merge_firedrake
uses: ./.github/workflows/docker_build.yml
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ name: Publish release

on:
release:
types: [published]
types: [released]

jobs:
deploy:
if: '!startsWith( github.ref_name, ''Zenodo'' )'
uses: ./.github/workflows/core.yml
with:
source_ref: release
Expand All @@ -16,9 +15,8 @@ jobs:
secrets: inherit

docker:
if: '!startsWith( github.ref_name, ''Zenodo'' )'
name: Build Docker containers
uses: ./.github/workflows/docker.yml
with:
tag: ${{ github.ref }}
tag: ${{ github.ref_name }}
secrets: inherit
Loading