Skip to content
This repository was archived by the owner on Mar 7, 2021. It is now read-only.

Burn down a TODO about modinfo name now that we have const fns #75

Closed
wants to merge 2 commits into from

Conversation

alex
Copy link
Member

@alex alex commented Apr 28, 2019

No description provided.

Copy link
Collaborator

@geofft geofft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the #![feature(const_str_as_bytes)] be in the linux_kernel_module crate instead of one specific module? Or do macros make this hard?

If this needs to go into every kernel module, I'd prefer we hold off until it's stable I think.

@alex
Copy link
Member Author

alex commented Apr 30, 2019

Yes, this needs to go into the calling module because of macros.

@alex
Copy link
Member Author

alex commented Apr 30, 2019

On further thought I don't even think this is correct. To get the memory representation of a const char [] the type needs to be [u8; _], not &[u8].

@geofft
Copy link
Collaborator

geofft commented May 5, 2019

This is one of the changes in #67, we should resolve whether we want it or not.

@geofft
Copy link
Collaborator

geofft commented May 6, 2019

Merged as 3a38379 - opened #80 to track the TODO about [u8; _].

@geofft geofft closed this May 6, 2019
@alex alex deleted the modinfo-bytes branch December 25, 2019 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants