Skip to content

add -nographic flag for x86_64 arch #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thebigbone
Copy link

Add -nographic in build_library/qemu_template.sh

Refer flatcar/Flatcar#1687

Testing done

  • Use the flag to boot up flatcar linux image on a headless x86_64 system and it works fine.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@tormath1 tormath1 requested a review from a team March 19, 2025 09:34
@chewi
Copy link
Contributor

chewi commented Mar 19, 2025

I was actually looking to go the other way and remove -nographic from all cases, as having the display can help diagnose some early boot issues. There were some driver-related issues with arm64 though, so I didn't push it yet. You can always add -- -nographic yourself if that's what you want.

Copy link

github-actions bot commented Mar 19, 2025

Build action triggered: https://github.com/flatcar/scripts/actions/runs/13947661546

@chewi
Copy link
Contributor

chewi commented Mar 19, 2025

Maybe we could make this automatic by checking the DISPLAY and WAYLAND_DISPLAY variables.

@jepio
Copy link
Member

jepio commented Mar 19, 2025

I manually provide either -nographic or -display curses on the flatcar_production_qemu.sh command line. One reason for the arm64/amd64 difference in -nographic: on arm64 the default console is the serial console, and on amd64 the default is tty0/tty1. So to get early kernel/initrd console output in -nographic mode on amd64 requires breaking in grub and appending console=ttyS0 to the kernel command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants