V2 track dependencies #4210
Draft
V2 track dependencies #4210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #4210 +/- ##
=====================================
Coverage ? 49.95%
=====================================
Files ? 120
Lines ? 12014
Branches ? 0
=====================================
Hits ? 6001
Misses ? 5557
Partials ? 456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
markphelps
commented
May 15, 2025
internal/storage/fs/snapshot.go
Outdated
| @@ -594,6 +629,12 @@ func (s *Snapshot) addDoc(doc *ext.Document) error { | |||
| } | |||
|
|
|||
| ns.evalRollouts[f.Key] = evalRollouts | |||
| if opts.dependencyGraph != nil { | |||
| opts.dependencyGraph.SetDependencies(&rpcenvironments.Resource{ | |||
There was a problem hiding this comment.
i need to rethink this as there wont be a TypeURL here
Signed-off-by: Mark Phelps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #4183
This adds a per env DependencyGraph that is build on each snapshot build. This allows us to track what is dependent on what, ie segments that are in use in rules/rollouts.
Then we can check when the user goes to delete if they are allowed to or not:
This is just a POC, I will likely clean this up and make the API a bit better for creating dependencies, but wanted to put it out there to get feedback
/cc @erka