Skip to content

TASK: Improve flushByTags performance #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

daniellienert
Copy link
Contributor

This backports the optimized code from the redis backend of the neos/cache package. (https://github.com/neos/flow-development-collection/blob/8.3/Neos.Cache/Classes/Backend/RedisBackend.php#L297)

@daniellienert
Copy link
Contributor Author

In my test environment, the optimized method saves about 30 seconds when publishing a page with ~300 nodes.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 28.39%. Comparing base (8a12033) to head (99a7bd1).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
Classes/RedisBackend.php 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #32      +/-   ##
============================================
- Coverage     28.86%   28.39%   -0.48%     
- Complexity      136      138       +2     
============================================
  Files             2        2              
  Lines           388      405      +17     
============================================
+ Hits            112      115       +3     
- Misses          276      290      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daniellienert daniellienert force-pushed the task/improve-flushByTags-perfoemance branch from 11401dd to fcdc3d1 Compare July 18, 2023 20:11
@daniellienert
Copy link
Contributor Author

Hey @robertlemke, hope you are doing well!
We are running our projects on this patch for nearly 2 years now. I guess it's worth a look ;)
Cheers
Daniel

Copy link
Member

@robertlemke robertlemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, sorry for the late review!

@robertlemke robertlemke merged commit e574fb8 into flownative:main Apr 28, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants