Skip to content

dockerfile: Windows Containers image Fluent Bit NMake build #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 21, 2025

Conversation

mabrarov
Copy link
Contributor

@mabrarov mabrarov commented Apr 7, 2025

This PR is based on (includes) #10178 and provides workaround for #10158 by using NMake (instead of MSBuild) when building Fluent Bit as part of building image for Windows Containers.

Changes (excluding #10178):

  • Building with NMake in image for Windows Containers.
  • Configurable version of MS Visual C++ used to build Fluent Bit within building of image for Windows Containers.
  • Removed unused DLLs (MS Visual C++ runtime libraries) from image for Windows Containers.

Testing

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found
  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@mabrarov mabrarov force-pushed the feature/windows_container_nmake branch from 372305f to da875e4 Compare April 7, 2025 01:25
@mabrarov mabrarov changed the title Windows Containers image Fluent Bit NMake build dockerfile: Windows Containers image Fluent Bit NMake build Apr 7, 2025
@mabrarov mabrarov force-pushed the feature/windows_container_nmake branch from da875e4 to 70467a4 Compare April 8, 2025 06:02
@mabrarov mabrarov force-pushed the feature/windows_container_nmake branch from 70467a4 to 22fa55e Compare April 8, 2025 07:08
…CMake projects not compatible with CMake 4.0 (actions/runner-images#11926).

Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…ne for unit tests on s390x and riscv64.

Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…to ensure no build issue due to incompatibility with new CMake versions.

Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…ported one for Linux containers.

Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
…t Bit within building of image for Windows Containers.

Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
Signed-off-by: Eduardo Silva Pereira <eduardo@calyptia.com>
@edsiper
Copy link
Member

edsiper commented Apr 21, 2025

note: I found some conflicts, I tried to fix them manually ...

@edsiper edsiper merged commit ebc19e6 into fluent:master Apr 21, 2025
23 checks passed
@edsiper edsiper added this to the Fluent Bit v4.0.1 milestone Apr 21, 2025
@mabrarov
Copy link
Contributor Author

Hi @edsiper,

I'm not sure if it was intentional, but this pull request was merged partially. Please check #10233 which includes missed changes.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants