Skip to content

FIO-9813: Add validate when hidden property to the Nested Form if any of the children has it #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

FIO-9813: Add validate when hidden property to the Nested Form if any of the children has it #6047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/components/form/Form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,12 @@ export default class FormComponent extends Component {
// Iterate through every component and hide the submit button.
eachComponent(form.components, (component) => {
this.hideSubmitButton(component);
if (component.validateWhenHidden) {
this.component.validateWhenHidden = true;
// Change original component as well, so it won't cause any custom logic to be continuously triggered
// because the original component does not have this property
this.originalComponent.validateWhenHidden = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that we should not mutate the component by adding a property. I would rather add a non-enumerable property using Object.defineProperty.

Object.defineProperty(component, 'validateWhenHidden', {
  value: true,
  writable: true,
  enumerable: false
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @alexandraRamanenka - we're going to go with a top down approach for nested forms. In other words, the nested form component will add the "validateWhenHidden" property to its definition, and child components will respect that parent property

}
});

// If the subform is already created then destroy the old one.
Expand Down
Loading