Skip to content

FIO-8968: Displaying counter when toggle preview button #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yauheni-formio
Copy link

@yauheni-formio yauheni-formio commented Apr 18, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8968

Description

Fixed display of word and character counter when we hide and show preview of component. The default value index = 0 was added because in the case of the first render or click on the show/hide preview button we did not have access to index and index was undefined. It was the reason why the logic for setting the counter values didn't work.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

I added unit test.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@yauheni-formio yauheni-formio changed the title Fix/fio 8968 displaying counter when toggle preview button FIO-8968: Displaying counter when toggle preview button Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant