FIO-9813: Make validateWhenHidden to sepend on the parent component validateWhenHidden property #6099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9813
Description
Previously, validateWhenHidden was completely independent for every component and Nested Form did not have that property at all producing some unexpected results. Now any nested component will be validated being hidden only if 1. It has validateWhenHidden set to true & 2. If it's parent data component has validateWhenHidden set to true (if it is inside a parent data component)
Notice that the Nested Forms submitted as reference will still trigger the validation error for validateWhenhidden component even if the Nested Form component does not have validateWhenHidden property set. This is because server creates a separate submission for the nested form and validate it outside of the parent form context and such submission must be valid outside the parent's context, so this is a completely expected behaviour.
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
formio/core#229
How has this PR been tested?
Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning
Checklist: