Skip to content

FIO-9813: Make validateWhenHidden to sepend on the parent component validateWhenHidden property #6099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexandraRamanenka
Copy link
Contributor

@alexandraRamanenka alexandraRamanenka commented Apr 22, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9813

Description

Previously, validateWhenHidden was completely independent for every component and Nested Form did not have that property at all producing some unexpected results. Now any nested component will be validated being hidden only if 1. It has validateWhenHidden set to true & 2. If it's parent data component has validateWhenHidden set to true (if it is inside a parent data component)
Notice that the Nested Forms submitted as reference will still trigger the validation error for validateWhenhidden component even if the Nested Form component does not have validateWhenHidden property set. This is because server creates a separate submission for the nested form and validate it outside of the parent form context and such submission must be valid outside the parent's context, so this is a completely expected behaviour.

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

formio/core#229

How has this PR been tested?

Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant