Skip to content

FIO-9969: Fix conditional logic inside DataGrid component #6100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Apr 22, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9969

Description

Issue: The getRow method is intended to return raw data for conditionals. However, it currently uses localDataPath, which contains indices. As a result, it creates an object similar to data but with empty slots. Additionally, the simple conditional check only verifies a single-level parent to locate the data grid. This approach fails when there is a container inside the data grid, as the data grid cannot be detected.

Solution:

  • Replace localDataPath with localPath to ensure the correct row structure is created.
  • Implement a recursive check for the component's parent to detect the data grid at any level.

How has this PR been tested?

Unit testing

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant