Skip to content

FIO-9693: Fix select component with custom data source #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Apr 25, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9693

Description

Original issue: When clicking on a select component with a custom data source and default multiple values, the component reloads the custom values, clearing the default selected values and reassigning them in choices.js. This behavior causes visual flickering. The issue was initially resolved by upgrading choices.js, but this introduced a new problem.

Current Issue: The setChoices method in choices.js introduces a new parameter to replace items (selected options). By default, this parameter is set to false. As a result, on the initial load, a select component with a custom data source only knows the default values (without their corresponding labels, if they differ from the values). This leads to incorrect labels being displayed on the initial load.

Solution: To address this, we need to pass the additional parameter to replace selected items. This should only be done when the choices items have different labels compared to the last update. Otherwise, we risk introducing visual flickering again.

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant