FIO-9693: Fix select component with custom data source #6109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9693
Description
Original issue: When clicking on a select component with a custom data source and default multiple values, the component reloads the custom values, clearing the default selected values and reassigning them in
choices.js
. This behavior causes visual flickering. The issue was initially resolved by upgradingchoices.js
, but this introduced a new problem.Current Issue: The
setChoices
method in choices.js introduces a new parameter to replace items (selected options). By default, this parameter is set tofalse
. As a result, on the initial load, a select component with a custom data source only knows the default values (without their corresponding labels, if they differ from the values). This leads to incorrect labels being displayed on the initial load.Solution: To address this, we need to pass the additional parameter to replace selected items. This should only be done when the choices items have different labels compared to the last update. Otherwise, we risk introducing visual flickering again.
How has this PR been tested?
Manually
Checklist: