-
Notifications
You must be signed in to change notification settings - Fork 540
Onboarding Screen #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding Screen #670
Conversation
Is multiple commits an issue? If needed, I can squash them into one in a fresh repo for a cleaner commit history! Screenrecorder-2025-03-14-17-44-30-498.mp4 |
PR #671 is a better approach. |
@badnikhil I would like you to take it up as a homework and let us know why do you think we decided to go with 671 instead of this PR. |
My initial approach was quite similar to the merged one(adding onboarding inside the app), but my goal was to align with community expectations like minimum changes to current code structure and follow the most efficient and maintainable approach. I put in significant effort to make my PR better than the approach used in merged one. That being said, I want to emphasize that I fully respect your decision and I am not against it. However, I would like to share my perspective on why I believe my approach was more suitable:
The alternative approach using Additionally, the use of a package - introduction_screen :
flutter animate provides animations What i think is better in other approach is use of carousal slider: My sincere apologies if this sounds dumb. |
PR Description
I have added an Onboarding Screen with only one line change to the existing code!
Lottie Animation Sources:
→ lottie1.json
→ lottie2.json
→ lottie3.json
→ lottie3.json
Packages Added:
introduction_screen
(v3.1.8)flutter_animate
(v4.5.0)Related Issues
Checklist
main
branch before making this PRflutter upgrade
and verify)flutter test
) and all tests are passingAdded/updated tests?
OS on which you have developed and tested the feature?