Skip to content

allow threshold and name filters in forge snapshot #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattsse opened this issue Jul 26, 2022 · 1 comment
Closed

allow threshold and name filters in forge snapshot #2484

mattsse opened this issue Jul 26, 2022 · 1 comment
Assignees
@mattsse
Labels
A-gas-snapshots Area: gas snapshotting/reporting C-forge Command: forge first issue A good way to start contributing P-low Priority: low T-feature Type: feature
Milestone
v1.0.0

Comments

@mattsse
Copy link
Member

mattsse commented Jul 26, 2022 •
edited
Loading

Component

Forge

Describe the feature you would like

forge snapshot can be a bit pedantic:

https://twitter.com/devtooligan/status/1551965598149513216

image

there was some discussion re merging --gas-report and snapshot #2065 (comment) but given that both serve different purposes it wasn't merged yet.

forge snapshot has been neglected a bit #2056

adding thresholds and name filters would be a quick fix though

this also should be configurable via config, see #2509

Additional context

No response
@mattsse mattsse added the T-feature Type: feature label Jul 26, 2022
@gakonst gakonst moved this to Todo in Foundry Jul 26, 2022
@gakonst gakonst added this to Foundry Jul 26, 2022
@mattsse mattsse added the first issue A good way to start contributing label Jul 26, 2022
@mattsse mattsse changed the title allow thresholds in forge snapshot allow threshold and name filters in forge snapshot Jul 26, 2022
@onbjerg onbjerg added C-forge Command: forge A-gas-snapshots Area: gas snapshotting/reporting labels Jul 28, 2022
@mattsse mattsse mentioned this issue Jul 29, 2022
Closed
@onbjerg onbjerg added this to the v1.0.0 milestone Aug 11, 2022
@onbjerg onbjerg added the P-low Priority: low label Aug 11, 2022
@mattsse mattsse mentioned this issue Sep 6, 2022
Merged
@mattsse
Copy link
Member Author

mattsse commented Sep 12, 2022

closed by #3102

@mattsse mattsse closed this as completed Sep 12, 2022
Repository owner moved this from Todo to Done in Foundry Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
A-gas-snapshots Area: gas snapshotting/reporting C-forge Command: forge first issue A good way to start contributing P-low Priority: low T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@onbjerg @mattsse