You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We thought adding forge snapshot --check to our CI was a great idea. It forces the dev to acknowledge and review any changes to the gas profile. But it didn't turn out to be that helpful. Pretty much every change affects the gas profile a little. So what ended up happening was that devs never reviewed it, and it just became an annoyance solved by quickly running forge snapshot and pushing a new commit without even looking at it.
One idea to improve this feature might be to add some sort of thresholds. For example, in foundry.toml user selects the minimum change (nominal or percentage) that must be met before the snapshot check fails. example:
Component
Forge
Describe the feature you would like
We thought adding
forge snapshot --check
to our CI was a great idea. It forces the dev to acknowledge and review any changes to the gas profile. But it didn't turn out to be that helpful. Pretty much every change affects the gas profile a little. So what ended up happening was that devs never reviewed it, and it just became an annoyance solved by quickly running forge snapshot and pushing a new commit without even looking at it.One idea to improve this feature might be to add some sort of thresholds. For example, in foundry.toml user selects the minimum change (nominal or percentage) that must be met before the snapshot check fails. example:
Anyways, open to other ideas on how to solve the problem. This is something that was mentioned on Twitter and gakonst asked for a ticket.
Additional context
No response
The text was updated successfully, but these errors were encountered: