-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(forge): forge lint #10405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xrusowsky
wants to merge
114
commits into
foundry-rs:master
Choose a base branch
from
0xrusowsky:feat/forge-lint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(forge): forge lint #10405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(forge): Forge Lint
Open
DaniPopes
reviewed
May 8, 2025
DaniPopes
reviewed
May 8, 2025
Co-authored-by: DaniPopes <[email protected]>
0xrusowsky
commented
May 8, 2025
the ui tests for win are failing, I think is due to path in stderr? (like |
mattsse
pushed a commit
to foundry-rs/compilers
that referenced
this pull request
May 12, 2025
- prereq for forge lint PR foundry-rs/foundry#10405 - solar 0.1.3 requires rust 1.86 so this breaks compatibility with older rust versions - bump msrv
mattsse
pushed a commit
to foundry-rs/block-explorers
that referenced
this pull request
May 12, 2025
- prereq for forge lint PR foundry-rs/foundry#10405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR builds on top of the work that @0xKitsune did on #9590.
the proposed changes maintain most of the initial traits and structs + uses
trait EarlyLintPass
to adopt the clippy-like architecture that @DaniPopes requested.relevant changes:
Visit
trait is implemented by the helper structEarlyLintVisitor
rather than the individual lints.considerations:
i was unable to find any methods on the solar
Session
to get the warning/note counts (just errors), so for tests, i manually counted the occurrences from the buffer.since i wanted to minimize code duplication, i added an unnecessary boolean to the
SolidityLinter
which allows it write to the local buffer rather than stderr:imo it should be fine, as the runtime overhead should be minimal and it would probably be optimized by the compiler:
however, if this feels unacceptable, i could leave a clean
SolidityLinter
and implement aTestSolidityLinter
with duplicate the logicif the changes are validated i can add more lints and tests (so far i only added a minimal logic for
incorrect-shift
)