fix: handle empty receipt when transactions are discarded by RPCs #10457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeVikingMark
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mattsse
requested changes
May 7, 2025
crates/script/src/receipts.rs
Outdated
Comment on lines
41
to
42
| // Check if the receipt has valid block information | ||
| if receipt.block_number.is_none() || receipt.block_hash.is_none() || receipt.transaction_index.is_none() { |
There was a problem hiding this comment.
receipt usually should only return mined transactions, but I can see that some networks might behave that way.
since these are mostly faster L2s, I wonder if the better approach here would be, just retry a few times here?
mattsse
requested changes
May 8, 2025
crates/script/src/progress.rs
Outdated
Comment on lines
265
to
266
| error_msg += "\n\n Add `--resume` to your command to try and continue broadcasting "; | ||
| error_msg += "the transactions. This will attempt to resend transactions that were discarded by the RPC."; |
There was a problem hiding this comment.
I'd prefer a single raw string here r#""#
crates/script/src/receipts.rs
Outdated
Comment on lines
58
to
60
| } else { | ||
| // Receipt has valid block information, proceed normally | ||
| Ok(receipt.into()) |
There was a problem hiding this comment.
I'd like to lift this up, like
let is_pending = receipt.block_number.is_none() || receipt.block_hash.is_none() || receipt.transaction_index.is_none();
if !is_pnding {return Ok(receipt.into())}
crates/script/src/progress.rs
Outdated
|
|
||
| seq_progress.inner.write().finish_tx_spinner(tx_hash); | ||
| // Check if this is a retry error for empty receipts | ||
| if err.to_string().contains("Received an empty receipt") { |
There was a problem hiding this comment.
this isn't quite empty, but pending, can we update the wording here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes issue #10453 where some RPCs discard transactions but return empty receipts (with missing block information), causing the --resume flag to be ineffective when trying to retry these transactions.
Solution
PR Checklist