Skip to content

chore: replaced anvil DepositTransaction with just op_alloy::TxDeposit #10480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: replaced anvil DepositTransaction with just op_alloy::TxDeposit #10480

wants to merge 5 commits into from

Conversation

Rimeeeeee
Copy link
Contributor

fixes #10475

mattsse
mattsse requested changes May 9, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, only smol clippy issues left

@Rimeeeeee Rimeeeeee requested a review from mattsse May 9, 2025 08:51
mattsse
mattsse requested changes May 9, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit,

I think we should block merging this until we have #10454

@Rimeeeeee Rimeeeeee requested a review from mattsse May 9, 2025 12:22
mattsse
mattsse approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yash-atreya @zerosnacks can we merge this or should we delay to avoid conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace anvil DepositTransaction with just op_alloy::TxDeposit
2 participants
@Rimeeeeee @mattsse