chore: update nix flake #10485
chore: update nix flake #10485
Conversation
shaunkh
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
There was a problem hiding this comment.
unfamiliar with this or how to review
but this changes seem appropriate from what a can decipher
anyone familiar with nix @grandizzy @zerosnacks @yash-atreya ?
|
@mattsse ah didn't notice that PR yup, can merge it first and i'll update this PR after |
|
I can also update it based on this #9260 and add CI for the flake |
flake.nix
Outdated
| solc_0_8_27 | ||
| # default for foundry's tests | ||
| (solc.mkDefault pkgs solc_0_8_27) |
There was a problem hiding this comment.
The latest solc is now 0.8.30
There was a problem hiding this comment.
unstable unfortunately doesn't have 0.8.30 yet but i've just updated it to use solc directly from nixpkgs instead of needing on overlay per @beeb suggestion
|
Hey! I think there are some interesting points in this PR as well as #10316. Ideally we would merge them. Which one should we use to merge those ideas @zerosnacks ? |
Co-authored-by: sveitser <[email protected]>
|
@beeb Thanks!
Let's use this one to aggregate the proposals as this one has momentum right now I've copied the proposed CI flow with some minor modifications and pushed it to this branch with the original author included as co-author @shaunkh would you mind integrating changes you see fit from https://github.com/foundry-rs/foundry/blob/27279a03744124b42e166b2d4d8f4fdd3ffbd7bb/flake.nix? |
|
Will review shortly |
|
@zerosnacks pushed changes, lmk what you think |
| # Environment variables | ||
| RUST_SRC_PATH = "${toolchain}/lib/rustlib/src/rust/library"; | ||
| LD_LIBRARY_PATH = lib.makeLibraryPath [ pkgs.libusb1 ]; | ||
| CFLAGS = "-DJEMALLOC_STRERROR_R_RETURNS_CHAR_WITH_GNU_SOURCE"; |
There was a problem hiding this comment.
Ref for reviewers: https://github.com/foundry-rs/foundry/pull/9848/files, it is a fix for building tikv-jemalloc-sys
The nix flake dev shell needed some updating.