-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: bump revm #6281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump revm #6281
Conversation
snekmate error unrelated I believe #6277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 1 nit + I don't really like the memory field rename given its API is the same. Will raise a complaint with management on this.
:D while you're at it, consider moving this to revm: can also rename to |
Don't think it's unrelated (snekmate)
|
@DaniPopes is the same failing on master? https://github.com/foundry-rs/foundry/actions/runs/6826317453 |
No : #6280 |
46d4089
to
af7eec8
Compare
Maybe an overflow somewhere, I'm getting These functions have a lot of recursion, might be a bug in revm |
hmm, yeah this fails due to a memmory OOG, so I must have introduced recursion somewhere, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's send ittt
FYI, since bluealloy/revm#865 is not yet fixed and I keep pushing to my |
bump revm to same rev as reth
fix breaking changes:
_ref
suffix forDatabaseRef
the revm bump includes a fix for op transactions ref #6073
https://github.com/bluealloy/revm/blob/1609e07c68048909ad1682c98cf2b9baa76310b5/crates/revm/src/evm_impl.rs#L262
FYI @anikaraghu