Skip to content

fix(anvil): return correct block number for Arbitrum fork #7360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #6749

Solution

  • use storage.best_number for eth_blockNumber call
  • make sure best number is not overwritten when new blocks are mined
  • dump and load best_number from state file
  • fix issue reported with Arbitrum chain specifics not applied if --chain-id missing eth_blockNumber returns L1 block for Arbitrum fork #6749 (comment) by calling apply_chain_and_block_specific_env_changes after chain id fetched from provider

@grandizzy grandizzy marked this pull request as ready for review March 10, 2024 17:25
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_blockNumber returns L1 block for Arbitrum fork
2 participants