Skip to content

fix: avoid deadlock in nested shell calls #9245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 1, 2024

@DaniPopes DaniPopes force-pushed the dani/shell-deadlock branch from 85dc3a5 to 50070e4 Compare November 1, 2024 15:10
@DaniPopes DaniPopes enabled auto-merge (squash) November 1, 2024 15:17
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaniPopes!

Confirming this works on nested shell calls of arbitrary depth

        sh_println!("{:?}", {
            sh_println!("Outer")?;
            sh_println!("{:?}", {
                sh_println!("Middle")?;
                sh_println!("{:?}", {
                    sh_println!("Inner")?;
                    "deepest nested"
                })?;
                "nested middle"
            })?;
            "nested outer"
        })?;

@DaniPopes DaniPopes merged commit ea11082 into master Nov 1, 2024
21 checks passed
@DaniPopes DaniPopes deleted the dani/shell-deadlock branch November 1, 2024 15:30
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
* fix: avoid deadlock in nested shell calls

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants