-
Notifications
You must be signed in to change notification settings - Fork 7
Ngio projection task #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ngio projection task #937
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very promising, great to see how much ngio simplifies things. I added a few minor comments to the task code, will review the tests later :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few very minor comments. Besides that, all looks great and I'd say this PR is ready to be merged into dev-1.5!
@tcompa I have started refactoring the task tests (see the tests/task_v2). It would be great if you could go over it and look if it all looks alright for you. |
Quick generic question: will you include both old (non- |
My idea would be to keep both of them for now (at least during the refactoring of the first few tasks). We remove the ' task ' tests only when we are confident that the new Yes, we need to enable them! Sorry, I overlooked that |
I added some minor comments, but it definitely looks fine to me. |
ngio > 0.2
Checklist before merging
CHANGELOG.md