Skip to content

chore: handle InvalidJFSHeaderError in parseManifest #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

andrei0x309
Copy link
Contributor

Change Summary

In the case of InvalidJFSHeaderError, the error is not detected in the debugger and you just see the following image:

image

This change will catch this specific error for better DX.

Example using the command line:

Without any change:

image

Including the change

image

Merge Checklist

  • PR has a Changeset
  • PR includes documentation if necessary
  • PR updates the boilerplates if necessary

Copy link

vercel bot commented Mar 21, 2025

@andrei0x309 is attempting to deploy a commit to the Discove Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frames-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 10:17am
framesjs-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 10:17am
framesjs-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 10:17am

@davidfurlong
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants