Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display correct cert names #1353

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

huyenltnguyen
Copy link
Member

@huyenltnguyen huyenltnguyen commented Mar 27, 2025

Checklist:

Closes #1319

Screenshot

Simulator Screenshot - iPhone Xʀ - 2025-04-07 at 17 01 50

@huyenltnguyen huyenltnguyen changed the title chore: add waiting triage label to issue templates fix: display correct cert names Mar 27, 2025
@@ -403,7 +403,7 @@ class CertificationWidget extends StatelessWidget {
child: ListTile(
title: Text(
context.t.profile_view_cert(
cert['certTitle'].toString(),
cert['title'].toString(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items in modern and legacy certs arrays have a title property instead of certTitle:

@huyenltnguyen huyenltnguyen marked this pull request as ready for review March 27, 2025 06:21
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner March 27, 2025 06:21
@huyenltnguyen huyenltnguyen marked this pull request as draft March 28, 2025 07:15
@huyenltnguyen huyenltnguyen marked this pull request as ready for review April 7, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certification names are displayed as null in profile page
1 participant