feat: block layout v2 #1371
feat: block layout v2 #1371
Conversation
…and list view templates
…ith corresponding view models; rename BlockViewModel to BlockTemplateViewModel and update references
…odel; update BlockListView and BlockLinkView to accept new parameters
…tor and toggle button;
…ust padding and width for better responsiveness
… state; adjust layout for better responsiveness
…kGridView Co-authored-by: Huyen [email protected]
mobile-app/lib/ui/views/learn/block/templates/link/link_view.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Now there are 2 weird behaviours with scrolling:
- If there's less than 3 blocks, they're auto opened so when you scroll down to the end and scroll back up there's a jump sometimes. Like in the below video you'll see that while scrolling up from the button halfway through the second block it jumps to the first blocks list.
less-3.mp4
- If there's more than 3 blocks, the first block isn't open anymore. Also any open block will get auto-closed the moment it goes out of view
more-3.mp4
|
I will see what I can do about the scrolling issue tomorrow. Thanks for the detailed review. We can change the purple to the blue progressbar color? How does that sound? |
Yea thats better |
|
It seems like the progressbar color and the white color did not have a good contrast ratio. I have opted for another blue color we use. |
|
Alright, I think I fixed the issue with the jittering, do we want to keep the "open all" when only 3 or less blocks available. I have decided to make some minor changes to the dialogue UI, it now also has a hide and open button. Let me know what you think. This was quite a refactor. |
|
The only thing I still need to fix is the |
I think it's better if we just leave the first block open by default just like in the website |
|
Done that should be good now. |
…se state management
ref #1348