Skip to content

fix(UI): Clarify searchbar text #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(UI): Clarify searchbar text #1100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/i18n/locales/english/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"label": "Search",
"accessible-name": "Submit your search query",
"placeholder": {
"default": "Search our tutorials",
"numbered": "Search {{ roundedTotalRecords }}+ tutorials"
"default": "Search our news articles, tutorials and books",
"numbered": "Search {{ roundedTotalRecords }}+ news articles, tutorials and books"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moT01, what do you think of the copy? Which of the followings do you prefer?
Search our news articles, tutorials and books
Search our articles, tutorials, and books on /news
Search our articles, tutorials, and books on News
Search our articles, tutorials, and books on our publication
Search our articles, tutorials, and books on our News publication

},
"see-results": "See all results for {{ searchQuery }}",
"no-tutorials": "No tutorials found"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it consistent with the /learn, this could be changed to no-results and text to "No results found". src/_includes/assets/js/search-bar.js also would need to be changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also go in.

Expand Down
Loading