fix: resolve old fiber update caused by closure capture #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你改哪儿啦，俺肿么看不出来 |
if (hook.length === 0) 里的逻辑只会应用最早的fiber，而之后每次运行的函数应该对应新的fiber，就是那个update(current)，你打个唯一id给fiber，dispatch永远调的是最早的那个fiber |
|
这里照理说调用的就是 old fiber，但是具体为啥要这样，我给忘了当时是为了啥了，我给合并了吧，之后有问题再说 |
主要是我写示例写出bug了，props更新后这个old fiber还取的旧props |
|
okk，好嘞，问题不大 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.