Exposing react-virtualized row props #770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
reviewed
Jun 16, 2021
| @@ -603,6 +603,7 @@ class ReactSortableTree extends Component { | |||
| toggleChildrenVisibility={this.toggleChildrenVisibility} | |||
| {...sharedProps} | |||
| {...nodeProps} | |||
| {...rowProps} | |||
There was a problem hiding this comment.
What do you think about passing rowProps (or specific attributes such as rowProps.isScrolling) to generateNodeProps in line 573? Then, one could use these props from within generateNodeProps without having to define an own nodeContentRenderer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
react-virtualizedrowRenderer props such asisScrollingandisVisible.This allows theme developers to add UI specific to scrolling and in addition, address performance issues with the
isVisibleflag.Cross merge with: frontend-collective/react-sortable-tree-theme-file-explorer#30