Skip to content

Handling SUBACK with Failure code #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handling SUBACK with Failure code #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions mqtt-client/src/main/java/org/fusesource/mqtt/client/CallbackConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@
import java.net.InetSocketAddress;
import java.net.ProtocolException;
import java.net.SocketAddress;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.LinkedList;
import java.util.Map;
import java.util.*;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
Expand Down Expand Up @@ -800,6 +797,30 @@ private void completeRequest(short id, byte originalType, Object arg) {
}
}

private void completeRequestSubAck(short id, byte[] grantedQos) throws ProtocolException {
Request request = requests.remove(id);
if( request!=null ) {
assert SUBSCRIBE.TYPE==request.frame.messageType();
if(request.cb!=null) {
ArrayList<String> rejectedTopics = new ArrayList<String>(grantedQos.length);
for (int i = 0; i < grantedQos.length; i++) {
if(SUBACK.isFailureQos(grantedQos[i])) {
rejectedTopics.add(new SUBSCRIBE().decode(request.frame).topics()[i].toString());
}
}

if(!rejectedTopics.isEmpty()) {
((Callback<Void>)request.cb).onFailure(new ProtocolException("Server rejected subscribe to: " + Arrays.toString(rejectedTopics.toArray())));
}
if(rejectedTopics.size() < grantedQos.length) {
((Callback<Object>) request.cb).onSuccess(grantedQos);
}
}
} else {
handleFatalFailure(new ProtocolException("Command from server contained an invalid message id: " + id));
}
}

private void processFrame(MQTTFrame frame) {
try {
switch(frame.messageType()) {
Expand Down Expand Up @@ -838,7 +859,7 @@ private void processFrame(MQTTFrame frame) {
}
case SUBACK.TYPE: {
SUBACK ack = new SUBACK().decode(frame);
completeRequest(ack.messageId(), SUBSCRIBE.TYPE, ack.grantedQos());
completeRequestSubAck(ack.messageId(), ack.grantedQos());
break;
}
case UNSUBACK.TYPE: {
Expand Down
6 changes: 6 additions & 0 deletions mqtt-client/src/main/java/org/fusesource/mqtt/codec/SUBACK.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ public class SUBACK implements Message {
public static final byte[] NO_GRANTED_QOS = new byte[0];
public static final byte TYPE = 9;

private static final byte FAILURE_QOS = (byte)0x80;

private short messageId;
private byte[] grantedQos = NO_GRANTED_QOS;

Expand Down Expand Up @@ -70,6 +72,10 @@ public byte[] grantedQos() {
return grantedQos;
}

public static boolean isFailureQos(byte grantedQos) {
return grantedQos == FAILURE_QOS;
}

public SUBACK grantedQos(byte[] grantedQos) {
this.grantedQos = grantedQos;
return this;
Expand Down