Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release into master branch #3371

Merged
merged 32 commits into from
Feb 4, 2025
Merged

Merge release into master branch #3371

merged 32 commits into from
Feb 4, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 4, 2025

Created by GH Action

github-actions bot and others added 30 commits November 1, 2024 14:36
* move to set where applicable

* update test

* Fix gremlin select step

* remove  deprecated parameter

* use safe add of labels
* make orphaned search optional and increase limit

* testing updates

* typo

* sonar fixes
* New utils class

* integrate checks for views and schema compatibility

* update unit testing for new class

* tidy

* address comments

* typo
* new change graph access operation

* unit tests
* job tracker fixes

* fix test and copyright

* checkstyle

* sonarcloud fixes

* checkstyle

* Address comments

Co-authored-by: tb06904 <[email protected]>

---------

Co-authored-by: tb06904 <[email protected]>
* make getwalks get handled correctly

* force options on all sub operations

* typo

* preserve outer options on getwalks

* typo

* dont flatten getwalks op

* move block

* set opts early

* add missing all edge check

* integration tests

* test typo
* Gh-3350 Fed store fixes

* checkstyle

* debug

* undo

---------

Co-authored-by: tb06904 <[email protected]>
* gh-3359 Reduce number of vertex lookups for edges

Stop inV/outV performing a full vertex lookup
Add new methods for doing this when we want to traverse an Edge

* headers

* tidy and add tests

* javadoc
* fix joinITs and add defaultGraphIds to AllGraphInfo

* copyright

---------

Co-authored-by: p29876 <[email protected]>
cn337131 and others added 2 commits February 4, 2025 11:49
* update koryphe version

* test fix and copyright

---------

Co-authored-by: wb36499 <[email protected]>
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 86.45833% with 52 lines in your changes missing coverage. Please review.

Project coverage is 68.08%. Comparing base (31abc0e) to head (d7b1b59).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
...a/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraph.java 91.66% 6 Missing and 2 partials ⚠️
.../federated/simple/operation/ChangeGraphAccess.java 79.48% 8 Missing ⚠️
...v/gchq/gaffer/federated/simple/FederatedUtils.java 86.00% 4 Missing and 3 partials ⚠️
...store/operation/handler/OperationChainHandler.java 25.00% 5 Missing and 1 partial ⚠️
...eration/handler/misc/ChangeGraphAccessHandler.java 60.00% 2 Missing and 4 partials ⚠️
...va/uk/gov/gchq/gaffer/operation/impl/GetWalks.java 0.00% 1 Missing and 2 partials ⚠️
...affer/store/operation/handler/GetWalksHandler.java 25.00% 3 Missing ⚠️
...rpop/process/traversal/util/GafferVertexUtils.java 75.00% 1 Missing and 2 partials ⚠️
...e/operation/handler/FederatedOperationHandler.java 85.71% 3 Missing ⚠️
...q/gaffer/rest/handler/GremlinWebSocketHandler.java 87.50% 1 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3371      +/-   ##
============================================
+ Coverage     68.01%   68.08%   +0.07%     
  Complexity     2596     2596              
============================================
  Files           955      957       +2     
  Lines         30564    30687     +123     
  Branches       3376     3406      +30     
============================================
+ Hits          20787    20894     +107     
- Misses         8302     8311       +9     
- Partials       1475     1482       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wb36499 wb36499 merged commit 48747a8 into master Feb 4, 2025
28 of 29 checks passed
@wb36499 wb36499 deleted the release/2.3.2 branch February 4, 2025 15:51
@p29876 p29876 restored the release/2.3.2 branch February 4, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants