Fix premature cleanup in code coverage with multiple IsMain processes #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2025 13:08
There are some scenarios where a single process executes GeneXus objects which end up with IsMain being true For example, some GXTest/GXFlow code instantiates procedures without passing them a GxContext. This was making the coverage trace file to try a premature cleanup and the need to start another coverage session
- add a specific Id for .NET code coverage sessions (Id=3) - Add a public static OnExit entry to allow for third party code which instantiates objects that end up being marked as Main in the same process to do a proper cleanup before exiting the last object. - Update OnExit/1 to be more resilient by ensuring every DbgItem with ticks not set to have a valid tick count - Add (conditionally compiled) code to generate a verbose log file of the trace being written. To enable this trace you have to build GxClasses.dll with _LOG_WRITER symbol defined Issue: 202777
gusbro
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
approved these changes
Feb 25, 2025
gusbro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, some GXTest/GXFlow code instantiates procedures without passing them a GxContext.
This was making the coverage trace file to try a premature cleanup and the need to start another coverage session
Issue: 202777