Avoid null pointer exception crashing the webapp. #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to prevent null pointer exceptions from crashing the webapp by adding a dedicated catch block in the logout method.
- Added a catch block for NullPointerException in the logout method
- Introduced an import for ObjectUtils (currently unused)
Comment on lines
242
to
246
| } | ||
| catch (NullPointerException e) | ||
| { | ||
| log ("8 - NullPointerException " + e.getMessage()); | ||
| sessionInfo.exceptionHandler(new GXMailException(e.getMessage(), MAIL_ConnectionLost)); |
There was a problem hiding this comment.
Catching NullPointerException can mask underlying issues; consider refactoring the code to perform explicit null checks to prevent the exception from occurring.
Suggested change
| } | |
| catch (NullPointerException e) | |
| { | |
| log ("8 - NullPointerException " + e.getMessage()); | |
| sessionInfo.exceptionHandler(new GXMailException(e.getMessage(), MAIL_ConnectionLost)); |
Copilot uses AI. Check for mistakes.
Cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
iroqueta
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:203914