Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the extension metadata isn't getting passed through here correctly.
I've added a test case that shows that there are two places internally where the extension metadata is correct (assertions pass; the result of
return_field_from_args
and the value ofargs.return_field
ininvoke_with_args
). But if I collect the data into record batches withsql_df.collect()
, the result schema is missing the Arrow extension metadata (assertion fails).@timsaucer do you know if I'm doing something wrong here? Or maybe this is an edge case because I'm passing a literal into the SQL command (
"SELECT ST_Point(-71.104, 42.315);"
)?Elsewhere the extension metadata seemed to correctly exist on the schema of the resulting record batches. In particular, in the test testing
ST_AsBinary
the relevant line succeedsgeoarrow-rs/rust/geodatafusion/src/udf/native/io/wkb.rs
Lines 210 to 211 in 26f2b6a