Skip to content

chore: add Gemfile for metrics and lockfile for iOS #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philprime
Copy link

While refreshing the Apple code signing certificates and profiles I noticed that fastlane is set up at /metrics/fastlane but there is not /metrics/Gemfile, while there is one for /flutter/example/ios/Gemfile implicating the usage of bundle exec fastlane ....

AFAIK the Gemfile.lock should also be checked into version control, because you want to ensure that everyone is using the exact same versions of tooling. As I am not an active maintainer for sentry-dart I'll leave the decision to you if you want them checked in.

#skip-changelog

@philprime philprime self-assigned this Apr 23, 2025
@philprime philprime moved this to Needs Review in Mobile SDKs Apr 23, 2025
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (48a9615) to head (a7f4c63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2885      +/-   ##
==========================================
+ Coverage   87.63%   89.16%   +1.53%     
==========================================
  Files         272       93     -179     
  Lines        9032     3065    -5967     
==========================================
- Hits         7915     2733    -5182     
+ Misses       1117      332     -785     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 23, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1265.73 ms 1278.30 ms 12.56 ms
Size 8.43 MiB 10.01 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
891efac 1233.78 ms 1248.31 ms 14.53 ms
7659cbe 1246.70 ms 1265.88 ms 19.17 ms
7359546 1252.02 ms 1271.55 ms 19.53 ms
202b83f 1206.16 ms 1225.33 ms 19.16 ms
211a7aa 1258.02 ms 1275.65 ms 17.63 ms
613760b 1263.10 ms 1277.27 ms 14.16 ms
5e8d2b3 1255.71 ms 1267.98 ms 12.27 ms
280ab9f 1255.71 ms 1262.78 ms 7.06 ms
73d70bf 1249.08 ms 1268.41 ms 19.33 ms
6034b0a 1244.89 ms 1270.22 ms 25.33 ms

App size

Revision Plain With Sentry Diff
891efac 8.28 MiB 9.34 MiB 1.06 MiB
7659cbe 8.42 MiB 9.89 MiB 1.47 MiB
7359546 8.42 MiB 9.83 MiB 1.40 MiB
202b83f 8.33 MiB 9.40 MiB 1.07 MiB
211a7aa 8.10 MiB 9.18 MiB 1.08 MiB
613760b 8.15 MiB 9.13 MiB 1000.46 KiB
5e8d2b3 8.29 MiB 9.36 MiB 1.07 MiB
280ab9f 8.29 MiB 9.39 MiB 1.10 MiB
73d70bf 8.38 MiB 9.70 MiB 1.33 MiB
6034b0a 8.33 MiB 9.40 MiB 1.07 MiB

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 496.31 ms 538.78 ms 42.47 ms
Size 6.44 MiB 7.43 MiB 1010.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3adbea9 395.16 ms 447.88 ms 52.71 ms
8c0b6dc 454.21 ms 512.22 ms 58.01 ms
f25f207 341.40 ms 427.73 ms 86.34 ms
aed5947 295.70 ms 348.18 ms 52.48 ms
213fb39 509.17 ms 557.36 ms 48.20 ms
21845e2 345.08 ms 382.82 ms 37.74 ms
2b9937e 439.68 ms 478.38 ms 38.70 ms
d61cecf 339.69 ms 387.57 ms 47.88 ms
6d7a391 331.94 ms 367.04 ms 35.10 ms
6edf8b8 486.35 ms 547.52 ms 61.17 ms

App size

Revision Plain With Sentry Diff
3adbea9 6.52 MiB 7.61 MiB 1.09 MiB
8c0b6dc 6.49 MiB 7.56 MiB 1.07 MiB
f25f207 6.33 MiB 7.26 MiB 943.41 KiB
aed5947 5.94 MiB 6.96 MiB 1.02 MiB
213fb39 6.44 MiB 7.43 MiB 1010.28 KiB
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB
2b9937e 6.49 MiB 7.56 MiB 1.07 MiB
d61cecf 6.06 MiB 7.03 MiB 995.56 KiB
6d7a391 5.94 MiB 6.95 MiB 1.01 MiB
6edf8b8 6.44 MiB 7.43 MiB 1010.28 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

2 participants