Skip to content

RN: Adds feedback widget theme documentation #13513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: antonis/rn-feedback-button
Choose a base branch
from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Apr 25, 2025

⚠️ PR Chain:

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

Adds feedback widget theme documentation.

Part of getsentry/sentry-react-native#4302

Implementation PR: getsentry/sentry-react-native#4677

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Should be merged after getsentry/sentry-react-native#4726 is released

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) May 20, 2025 3:11pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 3:11pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 3:11pm

Copy link

codecov bot commented Apr 25, 2025

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/yIpT-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/yIpT-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

@sfanahata
Copy link
Contributor

Similar to the last PR, I'm not seeing, specifically, a reference to the theme keys listed in the suggested updates in our react-native SDKs. Thoughts, @krystofwoldrich?

@sfanahata sfanahata self-requested a review May 1, 2025 22:15
@antonis
Copy link
Collaborator Author

antonis commented May 2, 2025

a reference to the theme keys listed in the suggested updates in our react-native SDKs.

As the parent PR this should be merged after getsentry/sentry-react-native#4726 is released.

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
@lucas-zimerman
Copy link
Collaborator

Overall the PR looks good! We can approve it once a new release with the given features mentioned here are released.

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants