-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
RN: Adds feedback widget theme documentation #13513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: antonis/rn-feedback-button
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportBundle size has no change ✅ Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
Similar to the last PR, I'm not seeing, specifically, a reference to the theme keys listed in the suggested updates in our react-native SDKs. Thoughts, @krystofwoldrich? |
As the parent PR this should be merged after getsentry/sentry-react-native#4726 is released. |
docs/platforms/react-native/user-feedback/configuration/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
docs/platforms/react-native/user-feedback/configuration/index.mdx
Outdated
Show resolved
Hide resolved
Overall the PR looks good! We can approve it once a new release with the given features mentioned here are released. |
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Ty!
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
Adds feedback widget theme documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR: getsentry/sentry-react-native#4677
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Should be merged after getsentry/sentry-react-native#4726 is released
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES