Skip to content

docs(api): Use correct HTTP method for specific issue #13854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

NicoHinderling
Copy link
Contributor

DESCRIBE YOUR PR

While going through the API docs page, I noticed that the example around mutating issues uses the POST method, but earlier on this docs page, it explicitly states that any endpoints whose purpose is to just update should be a PUT. Moreover, the endpoints in this example are real and there is no POST for them.

IS YOUR CHANGE URGENT?

No

Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 3:56pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 28, 2025 3:56pm
sentry-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2025 3:56pm

@@ -124,19 +124,19 @@ Resources can get complicated when you need to expose batch operations vs single
Let's say for example we have an endpoint that mutates an issue:

```
POST /api/0/organizations/{org}/issues/{issue}/
PUT /api/0/organizations/{org}/issues/{issue}/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paragraph above still says POST. I think those should be aligned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops! updated it as well

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching this! 🏄‍♂️

@NicoHinderling NicoHinderling merged commit 362656a into master May 30, 2025
12 checks passed
@NicoHinderling NicoHinderling deleted the fix-api-design-example-verb branch May 30, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants