Skip to content

fix: only show missing authToken warning if release.create is true #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eni4sure
Copy link

Fixes #536

@lforst
Copy link
Member

lforst commented Mar 12, 2025

Hi, unfortunately we cannot merge this PR as-is because it will actually change whether the release management plugin is added or not, which controls a bunch of other things too. We would need to be a little bit smarter about this.

@eni4sure
Copy link
Author

@lforst That makes sense. I pushed an update to explicitly check if both release.create and release.finalize is set to false to disable releases. That should avoid any unintended changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont log warnings when certain features are disabled
2 participants