Test Common w/ multiple OTel versions & add compat with old OTel #4312
+161
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## ivana/potel/fix-propagate-scope-false #4312 +/- ##
======================================================================
Coverage 84.36% 84.37%
======================================================================
Files 144 144
Lines 14630 14637 +7
Branches 2325 2326 +1
======================================================================
+ Hits 12343 12350 +7
Misses 1561 1561
Partials 726 726
|
sentrivana
changed the title
sentrivana
changed the title
opentelemetry-distro versions
sentrivana
commented
Apr 17, 2025
sentrivana
commented
Apr 17, 2025
| @@ -70,7 +70,6 @@ def get_file_text(file_name): | |||
| "openai": ["openai>=1.0.0", "tiktoken>=0.3.0"], | |||
| "openfeature": ["openfeature-sdk>=0.7.1"], | |||
| "opentelemetry": ["opentelemetry-distro>=0.35b0"], | |||
| "opentelemetry-experimental": ["opentelemetry-distro"], | |||
There was a problem hiding this comment.
This is unused now
sentrivana
changed the base branch from
potel-base
to
ivana/potel/fix-propagate-scope-false
…/determine-lowest-otel-version
sentrivana
changed the title
opentelemetry-distro versions
sentrivana
changed the title
sentrivana
changed the title
sentrivana
changed the title
antonpirker
approved these changes
Apr 23, 2025
| gc.disable() | ||
| request.addfinalizer(gc.enable) | ||
|
|
||
| gc.collect() |
There was a problem hiding this comment.
moving this line is still necessary, even if we skip this test sometimes?
There was a problem hiding this comment.
Moving this makes the test suite pass locally on 3.8, so it's still an improvement though not in CI
sl0thentr0py
force-pushed
the
ivana/potel/fix-propagate-scope-false
branch
from
f835a19 to
a964676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch to OTel, the Common test suite is now dependent on an otel package, so it technically fits the toxgen usecase. By letting toxgen take care of it, we're making sure we're always testing a good range of otel versions, including the oldest one (to catch regressions) and the newest one (to catch incompatibilities early).
Couple things surfaced in terms of incompatibility with older versions:
span.set_status()changed at some point open-telemetry/opentelemetry-python@6e282d2. Added a compat version ofset_status()for older otel.Also included:
opentelemetry-experimentalextra (not used anymore)opentelemetry-sdkinstead ofopentelemetry-distro-- thedistroonly seems to be setting up some defaults that we're not usingCloses #3241