Skip to content

Export extraErrorDataIntegration #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

Export extraErrorDataIntegration #4762

merged 4 commits into from
Apr 23, 2025

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Apr 17, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Export extraErrorDataIntegration from '@sentry/react';

💡 Motivation and Context

Fixes #4758

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis antonis mentioned this pull request Apr 17, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.15 ms 379.92 ms -11.23 ms
Size 7.15 MiB 8.40 MiB 1.25 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a0b0298+dirty 424.06 ms 423.76 ms -0.30 ms
cdc3945+dirty 428.13 ms 443.92 ms 15.78 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
c2a4e9b+dirty 392.94 ms 474.55 ms 81.61 ms
e73d82f+dirty 377.67 ms 407.06 ms 29.39 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
8c88ac7+dirty 402.72 ms 434.32 ms 31.60 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
800171e+dirty 432.15 ms 549.63 ms 117.48 ms
a38594f+dirty 393.83 ms 422.12 ms 28.29 ms

App size

Revision Plain With Sentry Diff
a0b0298+dirty 7.15 MiB 8.39 MiB 1.23 MiB
cdc3945+dirty 7.15 MiB 8.39 MiB 1.23 MiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
c2a4e9b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
e73d82f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
8c88ac7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
800171e+dirty 7.15 MiB 8.38 MiB 1.23 MiB
a38594f+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: antonis/test-extraErrorDataIntegration

Startup times

Revision Plain With Sentry Diff
b1844a3+dirty 386.57 ms 379.38 ms -7.19 ms

App size

Revision Plain With Sentry Diff
b1844a3+dirty 7.15 MiB 8.40 MiB 1.25 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.42 ms 1230.40 ms -4.01 ms
Size 2.63 MiB 3.78 MiB 1.14 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
db3192f+dirty 1214.63 ms 1214.60 ms -0.03 ms
f54118b+dirty 1232.98 ms 1235.73 ms 2.76 ms
9cab16b+dirty 1237.76 ms 1234.00 ms -3.76 ms
776f0b5+dirty 1221.61 ms 1222.02 ms 0.41 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
49ea1eb+dirty 1215.20 ms 1218.10 ms 2.90 ms
1332acb+dirty 1230.53 ms 1234.54 ms 4.01 ms
31e279d+dirty 1223.15 ms 1227.47 ms 4.32 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
2de79dc+dirty 1216.22 ms 1229.24 ms 13.03 ms

App size

Revision Plain With Sentry Diff
db3192f+dirty 2.63 MiB 3.76 MiB 1.13 MiB
f54118b+dirty 2.36 MiB 3.10 MiB 757.51 KiB
9cab16b+dirty 2.36 MiB 3.08 MiB 737.23 KiB
776f0b5+dirty 2.63 MiB 3.76 MiB 1.13 MiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
49ea1eb+dirty 2.63 MiB 3.76 MiB 1.13 MiB
1332acb+dirty 2.36 MiB 3.11 MiB 759.86 KiB
31e279d+dirty 2.63 MiB 3.78 MiB 1.14 MiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
2de79dc+dirty 2.63 MiB 3.76 MiB 1.13 MiB

Previous results on branch: antonis/test-extraErrorDataIntegration

Startup times

Revision Plain With Sentry Diff
b1844a3+dirty 1216.90 ms 1228.45 ms 11.55 ms

App size

Revision Plain With Sentry Diff
b1844a3+dirty 2.63 MiB 3.78 MiB 1.14 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.74 ms 1220.00 ms 5.26 ms
Size 3.19 MiB 4.34 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
db3192f+dirty 1221.33 ms 1217.61 ms -3.71 ms
f54118b+dirty 1235.42 ms 1236.80 ms 1.38 ms
9cab16b+dirty 1236.10 ms 1247.16 ms 11.06 ms
776f0b5+dirty 1227.16 ms 1225.45 ms -1.71 ms
4a6664f+dirty 1218.77 ms 1221.07 ms 2.30 ms
49ea1eb+dirty 1225.63 ms 1228.55 ms 2.92 ms
1332acb+dirty 1243.98 ms 1241.12 ms -2.86 ms
31e279d+dirty 1251.92 ms 1254.54 ms 2.62 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
2de79dc+dirty 1217.27 ms 1222.55 ms 5.29 ms

App size

Revision Plain With Sentry Diff
db3192f+dirty 3.19 MiB 4.33 MiB 1.14 MiB
f54118b+dirty 2.92 MiB 3.67 MiB 770.05 KiB
9cab16b+dirty 2.92 MiB 3.64 MiB 743.06 KiB
776f0b5+dirty 3.19 MiB 4.33 MiB 1.14 MiB
4a6664f+dirty 2.92 MiB 3.60 MiB 702.09 KiB
49ea1eb+dirty 3.19 MiB 4.33 MiB 1.14 MiB
1332acb+dirty 2.92 MiB 3.67 MiB 772.45 KiB
31e279d+dirty 3.19 MiB 4.34 MiB 1.16 MiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
2de79dc+dirty 3.19 MiB 4.33 MiB 1.14 MiB

Previous results on branch: antonis/test-extraErrorDataIntegration

Startup times

Revision Plain With Sentry Diff
b1844a3+dirty 1218.83 ms 1227.15 ms 8.32 ms

App size

Revision Plain With Sentry Diff
b1844a3+dirty 3.19 MiB 4.34 MiB 1.16 MiB

@antonis antonis marked this pull request as ready for review April 22, 2025 08:57
@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 427.34 ms 460.74 ms 33.40 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1c65324 426.37 ms 460.36 ms 33.99 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
8f0282e 451.19 ms 451.69 ms 0.51 ms
c398f67 449.64 ms 461.38 ms 11.74 ms
8fe7c9d 437.52 ms 426.42 ms -11.10 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
484813b 434.55 ms 452.31 ms 17.75 ms
4ed9c54 446.27 ms 433.56 ms -12.71 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
3aecc61 479.21 ms 462.92 ms -16.29 ms

App size

Revision Plain With Sentry Diff
1c65324 17.73 MiB 19.95 MiB 2.21 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
8f0282e 17.75 MiB 20.13 MiB 2.38 MiB
c398f67 17.73 MiB 19.94 MiB 2.21 MiB
8fe7c9d 17.75 MiB 20.11 MiB 2.36 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
484813b 17.73 MiB 20.07 MiB 2.33 MiB
4ed9c54 17.75 MiB 20.12 MiB 2.37 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
3aecc61 17.74 MiB 20.10 MiB 2.36 MiB

lucas-zimerman
lucas-zimerman approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, LGTM!

krystofwoldrich
krystofwoldrich approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding it! Let's merge this after the 6.11.0 release to avoid conflicts on the main branch.

@antonis antonis mentioned this pull request Apr 23, 2025
Merged
@antonis antonis enabled auto-merge (squash) April 23, 2025 08:46
@antonis antonis merged commit 4b3f3a5 into main Apr 23, 2025
67 of 68 checks passed
@antonis antonis deleted the antonis/test-extraErrorDataIntegration branch April 23, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extraErrorDataIntegration is not exported from @sentry/core
3 participants
@antonis @lucas-zimerman @krystofwoldrich